From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755455AbbCROxr (ORCPT ); Wed, 18 Mar 2015 10:53:47 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34784 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755065AbbCROxp (ORCPT ); Wed, 18 Mar 2015 10:53:45 -0400 Date: Wed, 18 Mar 2015 15:53:40 +0100 From: Greg KH To: Amitoj Kaur Chawla Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH octeon-usb] fix 'line over 80 characters' Message-ID: <20150318145340.GA1048@kroah.com> References: <20150318144232.GA5973@amitoj-Inspiron-3542> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150318144232.GA5973@amitoj-Inspiron-3542> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 08:12:32PM +0530, Amitoj Kaur Chawla wrote: > > This file contained a warning of a line being over 80 characters and > so the file has been edited to remove that warning. > > Signed-off-by: Amitoj Kaur Chawla Why did you put the driver name within the []? It needs to go outside of it. > --- > drivers/staging/octeon-usb/octeon-hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c > index 1daeb31..c8df0c3 100644 > --- a/drivers/staging/octeon-usb/octeon-hcd.c > +++ b/drivers/staging/octeon-usb/octeon-hcd.c > @@ -2884,7 +2884,7 @@ static int __cvmx_usb_poll_channel(struct cvmx_usb_state *usb, int channel) > pipe->pid_toggle = 1; > if (__cvmx_usb_pipe_needs_split(usb, pipe)) > transaction->stage = > - CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE; > + CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE; This really doesn't help much, the original code is fine, there are better things to fix in this file :) thanks, greg k-h