From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755215AbbCRPBT (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Mar 2015 11:01:19 -0400
Received: from muru.com ([72.249.23.125]:38344 "EHLO muru.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750986AbbCRPBR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Mar 2015 11:01:17 -0400
Date: Wed, 18 Mar 2015 07:56:33 -0700
From: Tony Lindgren <tony@atomide.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Kishon Vijay Abraham I <kishon@ti.com>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
        Bin Liu <binmlist@gmail.com>, Brian Hutchinson <b.hutchman@gmail.com>,
        Felipe Balbi <balbi@ti.com>,
        Matthijs van Duin <matthijsvanduin@gmail.com>,
        Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH v2] phy: Add a driver for dm816x USB PHY
Message-ID: <20150318145632.GM31346@atomide.com>
References: <1426637554-27178-1-git-send-email-tony@atomide.com>
 <1426677211.15575.27.camel@x220>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426677211.15575.27.camel@x220>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Paul Bolle <pebolle@tiscali.nl> [150318 04:13]:
> Two trivialities I failed the spot the first time.
> 
> On Tue, 2015-03-17 at 17:12 -0700, Tony Lindgren wrote:
> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> > index 2962de2..c858c2b 100644
> > --- a/drivers/phy/Kconfig
> > +++ b/drivers/phy/Kconfig
> 
> > +config PHY_DM816X_USB
> > +	tristate "TI dm816x USB PHY driver"
> > +	depends on ARCH_OMAP2PLUS
> > +	select GENERIC_PHY
> > +	help
> > +	  Enable this for dm81xx USB to work."
> > +
> 
> A trailing double quote.

Oops thanks for spotting that, will remove.
 
> > --- /dev/null
> > +++ b/drivers/phy/phy-dm816x-usb.c
> 
> > +MODULE_ALIAS("platform: dm816x_usb");
> 
> That space looks odd. Will it be removed by scripts/mod/file2alias.c? Or
> will it end up in the mdule, in modules.alias, and presumably break
> something (I'm not sure what, actually)?
> 
> There are currently six other instances MODULE_ALIAS() that have a space
> there. That would mean they're all broken, somehow, which would be
> unlikely, so I guess it's just a stylistic nit.

That looks like copy paste error, will fix. It seems like a style issue,
there's commit dd64ad387cc0 ("phy: ti/omap: Fix modalias") fixing those
up for drivers/phy.

Regards,

Tony