From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754902AbbCRP1F (ORCPT ); Wed, 18 Mar 2015 11:27:05 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:34229 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750766AbbCRP1D (ORCPT ); Wed, 18 Mar 2015 11:27:03 -0400 Date: Wed, 18 Mar 2015 15:26:58 +0000 From: Lee Jones To: Jassi Brar Cc: Jassi Brar , "linux-arm-kernel@lists.infradead.org" , lkml , Devicetree List , kernel@stlinux.com Subject: Re: [PATCH 3/3] mailbox: Add support for ST's Mailbox IP Message-ID: <20150318152658.GO3318@x1> References: <1425379283-1567-1-git-send-email-lee.jones@linaro.org> <1425379283-1567-4-git-send-email-lee.jones@linaro.org> <20150318131226.GM3318@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Mar 2015, Jassi Brar wrote: > On Wed, Mar 18, 2015 at 6:42 PM, Lee Jones wrote: > > On Wed, 04 Mar 2015, Jassi Brar wrote: > > > >> > + > >> > + if ((!data) || (!sti_mbox_chan_is_tx(mbox))) > >> > > >> nit: too much protection. > > > > What makes you think that? > > > Usually we write > if (!data || !sti_mbox_chan_is_tx(mbox)) Ah, the parentheses. Yes, I agree. Thanks for clarifying. > >> > + mbox->irq = irq_create_mapping(mbinst->irq_domain, > >> > + mbox->rx_id); > >> > > >> simply assigning same IRQ to all controller DT nodes and using > >> IRQF_SHARED for the common handler, wouldn't work? > > > > I do have intentions to simplify this driver somewhat, but that will > > take some time as it will require a great deal of consultation and > > testing from the ST side. This is the current internal implementation > > which is used in the wild and has been fully tested. If you'll allow > > me to conduct my adaptions subsequently we can have full history and a > > possible reversion plan if anything untoward take place i.e. I mess > > something up. > > > OK, but wouldn't that break the bindings of this driver when you > eventually do that? That's going to happen regardless, since these bindings are already in use internally. Mainline (i.e. v4.0+) isn't going to be used in products for years to come, so we have a lot of time until any new bindings become ABI. > >> > + * struct sti_mbox_msg - sti mailbox message description > >> > + * @dsize: data payload size > >> > + * @pdata: message data payload > >> > + */ > >> > +struct sti_mbox_msg { > >> > + u32 dsize; > >> > + u8 *pdata; > >> > +}; > >> > > >> There isn't any client driver in this patchset to tell exactly, but it > >> seems the header could be split into one shared between mailbox > >> clients and provider and another internal to client/provider ? > > > > I believe only the above will be required by the client. Seems silly > > to create a client specific header just for that, don't you think? > > > Do you mean to have copies of the structure in controller and client driver? :O I do not. I planned on sharing the main header with with client also. But I guess by your reaction you suggest having a teeny client header as the best way forward then. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog