From: Greg KH <gregkh@linuxfoundation.org>
To: Bas Peters <baspeters93@gmail.com>
Cc: mdharm-usb@one-eyed-alien.net, linux-usb@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] drivers: usb: storage: datafab.c: clean up a variety of checkpatch errors.
Date: Wed, 18 Mar 2015 17:03:01 +0100 [thread overview]
Message-ID: <20150318160301.GA16548@kroah.com> (raw)
In-Reply-To: <1423348964-23882-4-git-send-email-baspeters93@gmail.com>
On Sat, Feb 07, 2015 at 11:42:44PM +0100, Bas Peters wrote:
> This patch cleans up a variety of checkpatch errors:
>
> Bunch of space issues.
> C99 comments converted to /* */ format.
> Some switch statement indentations.
> "foo * bar" -> "foo *bar"
>
> Signed-off-by: Bas Peters <baspeters93@gmail.com>
> ---
> drivers/usb/storage/datafab.c | 183 +++++++++++++++++++++---------------------
> 1 file changed, 93 insertions(+), 90 deletions(-)
You are doing multiple things in the same patch, please break this up
into one-thing-per-patch and send a patch series for this single file.
thanks,
greg k-h
prev parent reply other threads:[~2015-03-18 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 22:42 [PATCH 0/3] drivers: usb: storage: fix some checkpatch errors Bas Peters
2015-02-07 22:42 ` [PATCH 1/3] drivers: usb: storage: alauda.c: properly place braces after function declarations Bas Peters
2015-02-07 22:42 ` [PATCH 2/3] drivers: usb: storage: cypress_atacb.c: trivial checkpatch fixes Bas Peters
2015-02-08 11:24 ` Sergei Shtylyov
2015-02-07 22:42 ` [PATCH 3/3] drivers: usb: storage: datafab.c: clean up a variety of checkpatch errors Bas Peters
2015-03-18 16:03 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318160301.GA16548@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=baspeters93@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox