From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933707AbbCRQw2 (ORCPT ); Wed, 18 Mar 2015 12:52:28 -0400 Received: from mga02.intel.com ([134.134.136.20]:50055 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932739AbbCRQwX (ORCPT ); Wed, 18 Mar 2015 12:52:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,423,1422950400"; d="scan'208";a="469006502" Date: Wed, 18 Mar 2015 09:54:14 -0700 From: David Cohen To: Sergei Shtylyov Cc: Heikki Krogerus , Felipe Balbi , Greg Kroah-Hartman , Stephen Boyd , Baolu Lu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I Subject: Re: [PATCHv2 11/12] phy: helpers for USB ULPI PHY registering Message-ID: <20150318165414.GA25477@psi-dev26.jf.intel.com> References: <1426682433-133813-1-git-send-email-heikki.krogerus@linux.intel.com> <1426682433-133813-12-git-send-email-heikki.krogerus@linux.intel.com> <55098FD4.7080902@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55098FD4.7080902@cogentembedded.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 05:46:44PM +0300, Sergei Shtylyov wrote: > Hello. > > On 3/18/2015 3:40 PM, Heikki Krogerus wrote: > > >ULPI PHYs need to be bound to their controllers with a > >lookup. This adds helpers that the ULPI drivers can use to > >do both, the registration of the PHY and the lookup, at the > >same time. > > >Signed-off-by: Heikki Krogerus > >Cc: Kishon Vijay Abraham I > >--- > > drivers/phy/ulpi_phy.h | 31 +++++++++++++++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > create mode 100644 drivers/phy/ulpi_phy.h > > >diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h > >new file mode 100644 > >index 0000000..ac49fb6 > >--- /dev/null > >+++ b/drivers/phy/ulpi_phy.h > >@@ -0,0 +1,31 @@ > >+#include > >+ > >+/** > >+ * Helper that registers PHY for a ULPI device and adds a lookup for binding it > >+ * and it's controller, which is always the parent. > >+ */ > >+static inline struct phy > >+*ulpi_phy_create(struct ulpi *ulpi, struct phy_ops *ops) > > Please either keep the prototype on a single line or don't break it like > this. The result type should be all on the 1st line. IMHO this is quite fine and readable. We can find this style in many places of the kernel. Maybe it's a matter of taste :) BR, David > > [...] > > WBR, Sergei >