From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756234AbbCRRI7 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Mar 2015 13:08:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53502 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755301AbbCRRI4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Mar 2015 13:08:56 -0400
Date: Wed, 18 Mar 2015 18:06:55 +0100
From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Aaron Tomlin <atomlin@redhat.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Davidlohr Bueso <dave@stgolabs.net>,
        David Rientjes <rientjes@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Fabian Frederick <fabf@skynet.be>, Guenter Roeck <linux@roeck-us.net>,
        "H. Peter Anvin" <hpa@zytor.com>, Jens Axboe <axboe@fb.com>,
        Joe Perches <joe@perches.com>, Johannes Weiner <hannes@cmpxchg.org>,
        Jonathan Corbet <corbet@lwn.net>, Kees Cook <keescook@chromium.org>,
        Michael Marineau <mike@marineau.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Prarit Bhargava <prarit@redhat.com>, Rik van Riel <riel@redhat.com>,
        Rusty Russell <rusty@rustcorp.com.au>,
        Steven Rostedt <rostedt@goodmis.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Vladimir Davydov <vdavydov@parallels.com>,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/4 v6] kernel/fork.c: avoid division by zero
Message-ID: <20150318170655.GA30545@redhat.com>
References: <1426436018-5159-1-git-send-email-xypron.glpk@gmx.de> <1426436018-5159-3-git-send-email-xypron.glpk@gmx.de> <20150316074146.GB15458@gmail.com> <55087E40.1020800@gmx.de> <20150318164903.GA18069@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150318164903.GA18069@gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/18, Ingo Molnar wrote:
>
> But ... no strong feelings from me, I'm not NAK-ing it or anything,
> maybe I'd have used this well-known pattern:
>
> 	threads = min(max(MIN_THREADS, threads), MAX_THREADS);
>
> instead of:
>
> > >> +	if (threads > MAX_THREADS)
> > >> +		threads = MAX_THREADS;
> > >> +
> > >> +	if (threads < MIN_THREADS)
> > >> +		threads = MIN_THREADS;

	clamp(threads, MIN_THREADS, MAX_THREADS)

;)

Oleg.