From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756271AbbCRRKb (ORCPT ); Wed, 18 Mar 2015 13:10:31 -0400 Received: from mga14.intel.com ([192.55.52.115]:21587 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755301AbbCRRK2 (ORCPT ); Wed, 18 Mar 2015 13:10:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,423,1422950400"; d="scan'208";a="700552734" Date: Wed, 18 Mar 2015 10:12:13 -0700 From: David Cohen To: Heikki Krogerus Cc: Felipe Balbi , Greg Kroah-Hartman , Stephen Boyd , Baolu Lu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 00/12] usb: ulpi bus Message-ID: <20150318171213.GC25477@psi-dev26.jf.intel.com> References: <1426682433-133813-1-git-send-email-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426682433-133813-1-git-send-email-heikki.krogerus@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Mar 18, 2015 at 02:40:21PM +0200, Heikki Krogerus wrote: > > Major changes since v1: > - calling dwc3_phy_setup earlier and registering the ULPI interface there. > - new property to dwc3 for selecting the interface in case of UTMI+ and ULPI as > suggested by Felipe > - dwc3 soft reset before registration of the ULPI interface to sync the clocks > as suggested by David > - Including support for the BYT boards that have the GPIOs controlling the reset > and cs signals. > > > Heikki Krogerus (12): > usb: add bus type for USB ULPI > usb: dwc3: USB2 PHY register access bits > usb: dwc3: ULPI or UTMI+ select > usb: dwc3: store driver data earlier > usb: dwc3: cache hwparams earlier > usb: dwc3: soft reset to it's own function > usb: dwc3: setup phys earlier > usb: dwc3: add hsphy_interface property > usb: dwc3: pci: add quirk for Baytrails > usb: dwc3: add ULPI interface support > phy: helpers for USB ULPI PHY registering > phy: add driver for TI TUSB1210 ULPI PHY Except for my comment on patch "9/12", this version looks fine on my side. BR, David