From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756118AbbCRRua (ORCPT ); Wed, 18 Mar 2015 13:50:30 -0400 Received: from mail-ig0-f172.google.com ([209.85.213.172]:38443 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754563AbbCRRu2 (ORCPT ); Wed, 18 Mar 2015 13:50:28 -0400 Date: Wed, 18 Mar 2015 10:50:23 -0700 From: Dmitry Torokhov To: Tejun Heo Cc: Greg Kroah-Hartman , "Luis R . Rodriguez" , linux-kernel@vger.kernel.org, Arjan van de Ven , Rusty Russell , Olof Johansson , Tetsuo Handa Subject: Re: [PATCH 6/8] amd64_edac: enforce synchronous probe Message-ID: <20150318175023.GE11485@dtor-ws> References: <1421451197-19723-1-git-send-email-dmitry.torokhov@gmail.com> <1421451197-19723-7-git-send-email-dmitry.torokhov@gmail.com> <20150318165618.GB21564@htj.duckdns.org> <20150318174544.GD11485@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150318174544.GD11485@dtor-ws> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 10:45:44AM -0700, Dmitry Torokhov wrote: > On Wed, Mar 18, 2015 at 12:56:18PM -0400, Tejun Heo wrote: > > On Fri, Jan 16, 2015 at 03:33:15PM -0800, Dmitry Torokhov wrote: > > > From: Luis R. Rodriguez > > > > > > While testing asynchronous PCI probe on this driver I noticed it failed > > > so enforce just synchronouse probe for now. Asynchronous probe is not > > > used by default and requires userepace intervention. Patches for its > > > support will be merged later. > > > > > > The reason async probe fails is that the init call for this driver > > > relies on probe to have finished for at least one device. This needs to > > > be addressed before enabling async probe. > > > > I'm still kinda uncomfortable with this both white and black list > > behavior. If we're gonna do this, let's please drop the debug options > > and build proper blacklists; otherwise, this will never be complete > > and we're gonna left with the in-between situation forever. > > Without the debug options how can we do that? I will definitely not be > able to go through all the in-tree drivers myself and see if they can be > asynchronously probed or not. The most I can do is to try enabling the > option on our side and fixing the drivers/subsystems that fail with > asynchronous probing. This will be iterative process for some time and > then we'll drop the debug option and flip the flag to do asynchronous > probing by default. By the way, at that point I think we should be able to remove the FORCE_SYNCHRONOUS option (and maybe PREFER_ASYNCHRONOUS as well?). Thanks. -- Dmitry