Re: [PATCH v3 1/2] x86_64,signal: Fix SS handling for signals delivered to 64-bit programs

Andy Lutomirski
2015-04-10T22:16:44Z

On Fri, Apr 10, 2015 at 3:11 PM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> On Fri, Apr 10, 2015 at 02:59:19PM -0700, Andy Lutomirski wrote:
>>
>> As long as you're doing that, any chance you could remove CPREG1(gs)
>> and CPREG1(fs) as well? They haven't had any effect since
>> 2.5.something_very_old, and the kernel might want to reuse those
>> sigcontext slots some day.
>
> Yeah, absolutely. I'm implementing 32bits support for criu now
> so I managed to postprone this task but will implement on the
> week. Thanks for reminder!

Yikes, have fun with that. I think there's a major vdso issue you'll
hit. Make sure you test on Intel hardware. I'll try to help if you
find stuff in my areas of the kernel.

--Andy

--
Andy Lutomirski
AMA Capital Management, LLC