Re: [PATCH v3 1/2] x86_64,signal: Fix SS handling for signals delivered to 64-bit programs

Andy Lutomirski
2015-03-18T21:27:05Z

On Wed, Mar 18, 2015 at 1:02 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> On 03/18, Andrey Wagin wrote:
>>
>> This patch fixes the problem. Oleg, could you send this path in the
>> criu maillist?
>
> Sure, will do.

We still haven't answered one question: what's the kernel's position
on ABI stability wrt CRIU? We clearly shouldn't make changes that
break the principle of CRIU, but CRIU encodes so many tricky
assumptions about the inner workings of the kernel that it's really
tough to avoid breaking old CRIU versions.

So... do we introduce somewhat nasty code into the kernel to keep old
CRIU versions working, or do we require that users who want to restore
onto new kernels use new CRIU?

(It seems clear to me that CRIU should apply the patch regardless of
what the kernel does. It will enable CRIU to work on the same class
of programs that are fixed by the kernel change that started this
thread.)

--Andy