From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933575AbbCRTlZ (ORCPT ); Wed, 18 Mar 2015 15:41:25 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:34583 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755456AbbCRTlV (ORCPT ); Wed, 18 Mar 2015 15:41:21 -0400 Date: Wed, 18 Mar 2015 13:41:15 -0600 From: Lina Iyer To: Bjorn Andersson Cc: Ohad Ben-Cohen , "linux-arm-msm@vger.kernel.org" , Jeffrey Hugo , Suman Anna , Andy Gross , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v6 2/2] hwspinlock: qcom: Add support for Qualcomm HW Mutex block Message-ID: <20150318194115.GE491@linaro.org> References: <1425076217-10415-1-git-send-email-bjorn.andersson@sonymobile.com> <1425076217-10415-2-git-send-email-bjorn.andersson@sonymobile.com> <20150312222904.GG497@linaro.org> <20150318161203.GZ26334@sonymobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20150318161203.GZ26334@sonymobile.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18 2015 at 10:12 -0600, Bjorn Andersson wrote: >On Thu 12 Mar 15:29 PDT 2015, Lina Iyer wrote: > >> On Fri, Feb 27 2015 at 15:30 -0700, Bjorn Andersson wrote: >> >Add driver for Qualcomm Hardware Mutex block found in many Qualcomm >> >SoCs. >> > >> >Based on initial effort by Kumar Gala >> > >> >Signed-off-by: Bjorn Andersson >> >+config HWSPINLOCK_QCOM >> >+ tristate "Qualcomm Hardware Spinlock device" Any reason, why this is tristate and not a bool? >> >+ depends on ARCH_QCOM >> >+ select HWSPINLOCK >> >> select MFD_SYSCON as well, perhaps? >> We seem to be dependent on it. >> > >Right, missed that. Thanks! > >Will resend with that addition. > >Regards, >Bjorn >