linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: alex.williamson@redhat.com, kvm@vger.kernel.org
Cc: linux-pci@vger.kernel.org, bsd@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/6] vgaarb: Stub vga_set_legacy_decoding()
Date: Wed, 18 Mar 2015 14:13:12 -0600	[thread overview]
Message-ID: <20150318201312.24807.70196.stgit@gimli.home> (raw)
In-Reply-To: <20150318200053.24807.74115.stgit@gimli.home>

vga_set_legacy_decoding() is defined in drivers/gpu/vga/vgaarb.c,
which is only compiled with CONFIG_VGA_ARB.  A caller would
therefore get an undefined symbol if the VGA arbiter is not
enabled.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Acked-by: Dave Airlie <airlied@redhat.com>
---
 include/linux/vgaarb.h |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h
index c37bd4d..8c3b412 100644
--- a/include/linux/vgaarb.h
+++ b/include/linux/vgaarb.h
@@ -65,8 +65,13 @@ struct pci_dev;
  *     out of the arbitration process (and can be safe to take
  *     interrupts at any time.
  */
+#if defined(CONFIG_VGA_ARB)
 extern void vga_set_legacy_decoding(struct pci_dev *pdev,
 				    unsigned int decodes);
+#else
+static inline void vga_set_legacy_decoding(struct pci_dev *pdev,
+					   unsigned int decodes) { };
+#endif
 
 /**
  *     vga_get         - acquire & locks VGA resources


  reply	other threads:[~2015-03-18 20:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 20:13 [PATCH v2 0/6] vfio-pci: Misc enhancements Alex Williamson
2015-03-18 20:13 ` Alex Williamson [this message]
2015-03-18 20:13 ` [PATCH v2 2/6] vfio-pci: Add module option to disable VGA region access Alex Williamson
2015-03-18 20:13 ` [PATCH v2 3/6] vfio-pci: Add VGA arbiter client Alex Williamson
2015-03-18 20:13 ` [PATCH v2 4/6] vfio-pci: Allow PCI IDs to be specified as module options Alex Williamson
2015-03-18 20:13 ` [PATCH v2 5/6] vfio-pci: Remove warning if try-reset fails Alex Williamson
2015-03-18 20:13 ` [PATCH v2 6/6] vfio-pci: Move idle devices to D3hot power state Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150318201312.24807.70196.stgit@gimli.home \
    --to=alex.williamson@redhat.com \
    --cc=bsd@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).