From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756598AbbCRUa2 (ORCPT ); Wed, 18 Mar 2015 16:30:28 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38060 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753067AbbCRUa1 (ORCPT ); Wed, 18 Mar 2015 16:30:27 -0400 Date: Wed, 18 Mar 2015 21:30:22 +0100 From: "gregkh@linuxfoundation.org" To: "Dilger, Andreas" Cc: Maxime Lorrillere , "linux-kernel@vger.kernel.org" , "laure.millet@lip6.fr" Subject: Re: [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit Message-ID: <20150318203022.GA3288@kroah.com> References: <1426705646-11943-1-git-send-email-maxime.lorrillere@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 07:53:35PM +0000, Dilger, Andreas wrote: > On 2015/03/18, 1:07 PM, "Maxime Lorrillere" > wrote: > > >From: Laure Millet > > > >This patch fixes lines over 80 characters > > I think the newer rule is that strings shouldn't be split across lines. > That makes > the first hunk invalid, though the second one is OK. No, that first hunk is just fine, that horrid DFID macro allows it to now be split :) To fix this correctly, you need to move to using the "real" in-kernel pr_err() functions, not custom macros. When that happens, checkpatch.pl will stop complaining. I'll take this one as-is. thanks, greg k-h