From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757032AbbCRV74 (ORCPT ); Wed, 18 Mar 2015 17:59:56 -0400 Received: from seldrel01.sonyericsson.com ([212.209.106.2]:14094 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756544AbbCRV7x (ORCPT ); Wed, 18 Mar 2015 17:59:53 -0400 Date: Wed, 18 Mar 2015 14:59:48 -0700 From: Bjorn Andersson To: Lina Iyer CC: Ohad Ben-Cohen , "linux-arm-msm@vger.kernel.org" , Jeffrey Hugo , Suman Anna , Andy Gross , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v6 2/2] hwspinlock: qcom: Add support for Qualcomm HW Mutex block Message-ID: <20150318215947.GA26334@sonymobile.com> References: <1425076217-10415-1-git-send-email-bjorn.andersson@sonymobile.com> <1425076217-10415-2-git-send-email-bjorn.andersson@sonymobile.com> <20150312193150.GB497@linaro.org> <20150318155553.GX26334@sonymobile.com> <20150318164532.GD491@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150318164532.GD491@linaro.org> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 18 Mar 09:45 PDT 2015, Lina Iyer wrote: > On Wed, Mar 18 2015 at 09:56 -0600, Bjorn Andersson wrote: > >On Thu 12 Mar 12:31 PDT 2015, Lina Iyer wrote: > > > >> On Fri, Feb 27 2015 at 15:30 -0700, Bjorn Andersson wrote: [..] > >> >+#define QCOM_MUTEX_NUM_LOCKS 32 > >> > >> Also, talking to Jeff it seems like that out of the 32 locks defined > >> only 8 is accessible from Linux. So its unnecessary and probably > >> incorrect to assume that there are 32 locks available. > >> > > > >The hardware block have 32 locks and the decision regarding which locks > >this particular Linux system is allowed to access is configuration. > > > Understood. But while the hardware may support it, it may be right for > Linux to be allowed to configure, giving a false sense of number of > locks. > You're not just randomly allocating these locks, the "sense of number of locks" is most likely carried in an Excel sheet within Qualcomm. Obviously the number 8 is arbitrary and a change of it is a question of "system configuration" and not a matter of changing the implementation of this device driver. Regards, Bjorn