From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754535AbbCSAmd (ORCPT ); Wed, 18 Mar 2015 20:42:33 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:33346 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbbCSAm3 (ORCPT ); Wed, 18 Mar 2015 20:42:29 -0400 Date: Thu, 19 Mar 2015 09:42:21 +0900 From: Minchan Kim To: "Wang, Yalin" Cc: Andrew Morton , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Michal Hocko , Johannes Weiner , Mel Gorman , Rik van Riel , Shaohua Li Subject: Re: [RFC] mm:do recheck for freeable page in reclaim path Message-ID: <20150319004221.GB9153@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Do not send your patch to this thread. It's second time. Your patch is totally irrelevant to this patchset. Send your patch as another thread. On Wed, Mar 11, 2015 at 05:47:28PM +0800, Wang, Yalin wrote: > In reclaim path, if encounter a freeable page, > the try_to_unmap may fail, because the page's pte is > dirty, we can recheck this page as normal non-freeable page, > this means we can swap out this page into swap partition. Pz, Pz, Pz write down more detail in description. You mean page_check_references in shrink_page_list decided it as freeable page but try_to_unmap failed because someone touched the page during the race window between page_check_references and try_to_unmap in shrink_page_list? If so, it's surely recent referenced page so it should be promoted to active list. If I missed something, please write it down more detail in description and send a patch as new thread, not sending it to this patchset thread. -- Kind regards, Minchan Kim