From: Wanpeng Li <wanpeng.li@linux.intel.com>
To: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@arm.com>,
linux-kernel@vger.kernel.org,
Wanpeng Li <wanpeng.li@linux.intel.com>
Subject: Re: [PATCH v3 1/2] sched/deadline: don't need to check throttled status when switched to dl
Date: Thu, 19 Mar 2015 12:20:24 +0800 [thread overview]
Message-ID: <20150319042024.GA7203@kernel> (raw)
In-Reply-To: <1426590931-4639-1-git-send-email-wanpeng.li@linux.intel.com>
Hi Ingo, how about these three patches this time, sorry for my bad english.
On Tue, Mar 17, 2015 at 07:15:30PM +0800, Wanpeng Li wrote:
>After commit 40767b0dc768 ("sched/deadline: Fix deadline parameter
>modification handling") is merged, deadline task throttled status
>is cleared each time once switch from dl class, so throttled status
>always doesn't set when switch back, there is no need to check
>throttled status, this patch drop the check.
>
>Acked-by: Juri Lelli <juri.lelli@arm.com>
>Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
>---
>v2 -> v3:
> * update changelog
>
> kernel/sched/deadline.c | 8 --------
> 1 file changed, 8 deletions(-)
>
>diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
>index 27b9381..eed6529 100644
>--- a/kernel/sched/deadline.c
>+++ b/kernel/sched/deadline.c
>@@ -1722,14 +1722,6 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p)
> {
> int check_resched = 1;
>
>- /*
>- * If p is throttled, don't consider the possibility
>- * of preempting rq->curr, the check will be done right
>- * after its runtime will get replenished.
>- */
>- if (unlikely(p->dl.dl_throttled))
>- return;
>-
> if (task_on_rq_queued(p) && rq->curr != p) {
> #ifdef CONFIG_SMP
> if (p->nr_cpus_allowed > 1 && rq->dl.overloaded &&
>--
>1.9.1
next prev parent reply other threads:[~2015-03-19 4:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 11:15 [PATCH v3 1/2] sched/deadline: don't need to check throttled status when switched to dl Wanpeng Li
2015-03-17 11:15 ` [PATCH v3 2/2] sched/deadline: fix rt runtime corrupt when dl refuse a smaller bandwidth Wanpeng Li
2015-03-27 11:44 ` [tip:sched/core] sched/deadline: Fix rt runtime corruption when dl fails its global constraints tip-bot for Wanpeng Li
2015-03-19 4:20 ` Wanpeng Li [this message]
2015-03-27 11:43 ` [tip:sched/core] sched/deadline: Avoid a superfluous check tip-bot for Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319042024.GA7203@kernel \
--to=wanpeng.li@linux.intel.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).