From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752017AbbCSEia (ORCPT ); Thu, 19 Mar 2015 00:38:30 -0400 Received: from mga14.intel.com ([192.55.52.115]:14283 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750901AbbCSEi3 (ORCPT ); Thu, 19 Mar 2015 00:38:29 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,427,1422950400"; d="scan'208";a="682263944" Date: Thu, 19 Mar 2015 12:20:24 +0800 From: Wanpeng Li To: Ingo Molnar Cc: Peter Zijlstra , Juri Lelli , linux-kernel@vger.kernel.org, Wanpeng Li Subject: Re: [PATCH v3 1/2] sched/deadline: don't need to check throttled status when switched to dl Message-ID: <20150319042024.GA7203@kernel> Reply-To: Wanpeng Li References: <1426590931-4639-1-git-send-email-wanpeng.li@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426590931-4639-1-git-send-email-wanpeng.li@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ingo, how about these three patches this time, sorry for my bad english. On Tue, Mar 17, 2015 at 07:15:30PM +0800, Wanpeng Li wrote: >After commit 40767b0dc768 ("sched/deadline: Fix deadline parameter >modification handling") is merged, deadline task throttled status >is cleared each time once switch from dl class, so throttled status >always doesn't set when switch back, there is no need to check >throttled status, this patch drop the check. > >Acked-by: Juri Lelli >Signed-off-by: Wanpeng Li >--- >v2 -> v3: > * update changelog > > kernel/sched/deadline.c | 8 -------- > 1 file changed, 8 deletions(-) > >diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c >index 27b9381..eed6529 100644 >--- a/kernel/sched/deadline.c >+++ b/kernel/sched/deadline.c >@@ -1722,14 +1722,6 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p) > { > int check_resched = 1; > >- /* >- * If p is throttled, don't consider the possibility >- * of preempting rq->curr, the check will be done right >- * after its runtime will get replenished. >- */ >- if (unlikely(p->dl.dl_throttled)) >- return; >- > if (task_on_rq_queued(p) && rq->curr != p) { > #ifdef CONFIG_SMP > if (p->nr_cpus_allowed > 1 && rq->dl.overloaded && >-- >1.9.1