From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753790AbbCSIDB (ORCPT ); Thu, 19 Mar 2015 04:03:01 -0400 Received: from down.free-electrons.com ([37.187.137.238]:57098 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751930AbbCSICT (ORCPT ); Thu, 19 Mar 2015 04:02:19 -0400 Date: Thu, 19 Mar 2015 09:02:16 +0100 From: Boris Brezillon To: Alexandre Belloni Cc: Nicolas Ferre , Daniel Lezcano , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clocksource: atmel-st: select REGMAP_MMIO Message-ID: <20150319090216.634797ef@bbrezillon> In-Reply-To: <1426676795-29333-1-git-send-email-alexandre.belloni@free-electrons.com> References: <1426676795-29333-1-git-send-email-alexandre.belloni@free-electrons.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandre, On Wed, 18 Mar 2015 12:06:35 +0100 Alexandre Belloni wrote: > Enforce REGMAP_MMIO selection as the driver needs it. Else, it will still > compile with some warning about X1, x2 or sr being used uninitialized. > > Reported-by: fengguang.wu@intel.com > Signed-off-by: Alexandre Belloni > --- > Daniel, > > I think this should go through the at91 tree as the patch introducing that issue > went there. > > drivers/clocksource/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index 168035883afa..3cc97b217019 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -146,6 +146,7 @@ config ATMEL_PIT > config ATMEL_ST > bool > select CLKSRC_OF > + select REGMAP_MMIO Shouldn't we select MFD_SYSCON instead. Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com