From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753135AbbCSJbc (ORCPT ); Thu, 19 Mar 2015 05:31:32 -0400 Received: from mail.skyhub.de ([78.46.96.112]:35033 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbbCSJba (ORCPT ); Thu, 19 Mar 2015 05:31:30 -0400 Date: Thu, 19 Mar 2015 10:29:53 +0100 From: Borislav Petkov To: "Luck, Tony" Cc: Aravind Gopalakrishnan , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "slaoub@gmail.com" , "luto@amacapital.net" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: Re: [PATCH] x86, mce, severities: Add AMD severities function Message-ID: <20150319092953.GB10860@pd.tnic> References: <1426526164-3806-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <20150317102048.GG19645@pd.tnic> <5508756A.1090908@amd.com> <20150317184441.GI19645@pd.tnic> <3908561D78D1C84285E8C5FCA982C28F32A234ED@ORSMSX114.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F32A234ED@ORSMSX114.amr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 12:01:32AM +0000, Luck, Tony wrote: > One other thought. Instead of the run-time test to see if this is an AMD processor on every call > to this function, would it be cleaner to: > > 1) Rename existing mce_severity() function to mce_severity_intel() > 2) Declare a function pointer named mce_severity. > 3) Assign that pointer to the _intel() or _amd() function in mce_init() Yes, of course. We do that (or at least pretty close) in other paths too. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --