From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754599AbbCSJmd (ORCPT ); Thu, 19 Mar 2015 05:42:33 -0400 Received: from mail.skyhub.de ([78.46.96.112]:49508 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbbCSJmb (ORCPT ); Thu, 19 Mar 2015 05:42:31 -0400 Date: Thu, 19 Mar 2015 10:40:54 +0100 From: Borislav Petkov To: Dmitry Torokhov Cc: Doug Thompson , Tejun Heo , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, Mauro Carvalho Chehab , Tetsuo Handa , Olof Johansson , Arjan van de Ven , Greg Kroah-Hartman , "Luis R . Rodriguez" Subject: Re: [PATCH 3/3] EDAC: amd64_edac: decide if driver can load successfully early. Message-ID: <20150319094054.GC10860@pd.tnic> References: <1426726150-983-1-git-send-email-dmitry.torokhov@gmail.com> <1426726150-983-4-git-send-email-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1426726150-983-4-git-send-email-dmitry.torokhov@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 05:49:10PM -0700, Dmitry Torokhov wrote: > This change moves setting up PCI control that used to be done after > driver tried to bind to present PCI devices into the probe() method, > thus allowing probing to be done asynchronously, if needed. > > To keep as close as possible to the previous behavior we explicitly > check for presence of supported PCI devices; still we may end up with > driver loaded even if we did not bind to any of them (for example if ECC > is disabled). This is why I did the drv_instances hack - I don't want it to load if there's no ECC support on the system as it is confusing to people and tools. It'd need to be able for the async probing to unload the driver if not a single node instance loads successfully. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --