From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752725AbbCSLSX (ORCPT ); Thu, 19 Mar 2015 07:18:23 -0400 Received: from mail.skyhub.de ([78.46.96.112]:33158 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbbCSLSV (ORCPT ); Thu, 19 Mar 2015 07:18:21 -0400 Date: Thu, 19 Mar 2015 12:16:44 +0100 From: Borislav Petkov To: Alexander Kuleshov Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-kernel@vger.kernel.org, Mike Waychison , Greg KH Subject: Re: [PATCH] x86: remove unused get_bios_ebda_length Message-ID: <20150319111643.GA11530@pd.tnic> References: <1426762537-25273-1-git-send-email-kuleshovmail@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1426762537-25273-1-git-send-email-kuleshovmail@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 04:55:37PM +0600, Alexander Kuleshov wrote: > get_bios_ebda_length function from was added > in the 57d5f9f808b7650a92f31e9cd3acd3f415a22530 commit, but You probably should've added the people involved in that commit to CC. They might still need it, although I doubt it. :-) > still not uses anywhere, let's remove it. > > Signed-off-by: Alexander Kuleshov > --- > arch/x86/include/asm/bios_ebda.h | 21 --------------------- > 1 file changed, 21 deletions(-) > > diff --git a/arch/x86/include/asm/bios_ebda.h b/arch/x86/include/asm/bios_ebda.h > index aa6a317..2b00c77 100644 > --- a/arch/x86/include/asm/bios_ebda.h > +++ b/arch/x86/include/asm/bios_ebda.h > @@ -17,27 +17,6 @@ static inline unsigned int get_bios_ebda(void) > return address; /* 0 means none */ > } > > -/* > - * Return the sanitized length of the EBDA in bytes, if it exists. > - */ > -static inline unsigned int get_bios_ebda_length(void) > -{ > - unsigned int address; > - unsigned int length; > - > - address = get_bios_ebda(); > - if (!address) > - return 0; > - > - /* EBDA length is byte 0 of the EBDA (stored in KiB) */ > - length = *(unsigned char *)phys_to_virt(address); > - length <<= 10; > - > - /* Trim the length if it extends beyond 640KiB */ > - length = min_t(unsigned int, (640 * 1024) - address, length); > - return length; > -} > - > void reserve_ebda_region(void); > > #ifdef CONFIG_X86_CHECK_BIOS_CORRUPTION > -- > 2.3.3.472.g20ceeac.dirty > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --