From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755814AbbCSNVk (ORCPT ); Thu, 19 Mar 2015 09:21:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47614 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755728AbbCSNVh (ORCPT ); Thu, 19 Mar 2015 09:21:37 -0400 Date: Thu, 19 Mar 2015 14:21:33 +0100 From: Greg Kroah-Hartman To: Brian Russell Cc: "Hans J. Koch" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] uio: Fix uio driver to refcount device Message-ID: <20150319132133.GA3458@kroah.com> References: <550ACC1D.4020604@brocade.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <550ACC1D.4020604@brocade.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 01:16:13PM +0000, Brian Russell wrote: > Protect uio driver from its owner being unplugged while there are open fds. > Embed struct device in struct uio_device, use refcounting on device, free > uio_device on release. > info struct passed in uio_register_device can be freed on unregister, so null > out the field in uio_urnegister_device and check accesses. > > Signed-off-by: Brian Russell > --- > drivers/uio/uio.c | 63 +++++++++++++++++++++++++++++++--------------- > include/linux/uio_driver.h | 2 +- > 2 files changed, 44 insertions(+), 21 deletions(-) when sending new versions, you need to list down here what changed from the previous version. Please send a v5 with that, as I don't see what changed between v3 and v4 very easily. thanks, greg k-h