From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753650AbbCSOPp (ORCPT ); Thu, 19 Mar 2015 10:15:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48511 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751191AbbCSOPn (ORCPT ); Thu, 19 Mar 2015 10:15:43 -0400 Date: Thu, 19 Mar 2015 15:15:39 +0100 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: linux-fbdev@vger.kernel, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: Re: [PATCH 1/2] staging: sm750fb: remove 750LE code Message-ID: <20150319141539.GD7046@kroah.com> References: <1426771061-28103-1-git-send-email-sudipm.mukherjee@gmail.com> <20150319132236.GA3540@kroah.com> <20150319140328.GA31838@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150319140328.GA31838@sudip-PC> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 07:33:28PM +0530, Sudip Mukherjee wrote: > On Thu, Mar 19, 2015 at 02:22:36PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Mar 19, 2015 at 06:47:40PM +0530, Sudip Mukherjee wrote: > > > 750LE is a special version of the hardware with Ip Core and > > > Silicon Motion is making this hardware only for Huawei. It is not > > > available to anyone else. > > > > And Huawei doesn't run Linux? (hint, they do...) > > > > Why remove this if someone can use it? I don't understand. > > this is part of my conversation with Teddy Wang of Silicon Motion: > "I think you can remove it . SM750LE is a special version. And it's > just a IP core. No one except huawei will use it." > > and moreover I donot have that 750LE hardware to test any changes. > I just have the SM712 and SM750 hardware. so .... > > now, whatever you decide .. I will surely like to have the code in > place. I suggest to leave it, it's not costing anything to keep around, and I think you removed additional code with this patch anyway, which wasn't good... thanks, greg k-h