From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756098AbbCSO15 (ORCPT ); Thu, 19 Mar 2015 10:27:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49827 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725AbbCSO1v (ORCPT ); Thu, 19 Mar 2015 10:27:51 -0400 Date: Thu, 19 Mar 2015 10:27:50 -0400 From: Don Zickus To: David Ahern Cc: Arnaldo Carvalho de Melo , Jiri Olsa , LKML Subject: Re: perf: thread is its own parent Message-ID: <20150319142750.GH162412@redhat.com> References: <550A10B1.9080701@gmail.com> <20150319132048.GB162412@redhat.com> <550AD590.9090904@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <550AD590.9090904@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 07:56:32AM -0600, David Ahern wrote: > On 3/19/15 7:20 AM, Don Zickus wrote: > >Honestly I don't recall. The commit log tells you the problem I was trying > >to solve. Instead of parsing text strings from/proc/maps/, I believe > >it was waaaay faster to copy the thread maps. > > > >This could have been an oversight. I might have falsely assumed tgid == > >ppid? > > > >Are you finding a problem with it? > > > rebasing my scheduling timehist command to 4.0 and this change > breaks one of the options. If there are no objections I'll send a > patch along with others to set ptid and ppid to -1 (that's what it > is in 3.12). Hmm, I wonder if this is going to break our threading example. Perhaps not, now that Jiri made some other changes later. Feel free to post a patch, cc me please. I will patch our perf over here and have Joe Mario run some tests to see if we lose any data or not and let you know. Cheers, Don