From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756204AbbCSO2a (ORCPT ); Thu, 19 Mar 2015 10:28:30 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:33136 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753180AbbCSO20 (ORCPT ); Thu, 19 Mar 2015 10:28:26 -0400 Date: Thu, 19 Mar 2015 19:58:15 +0530 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: Re: [PATCH 1/2] staging: sm750fb: remove 750LE code Message-ID: <20150319142815.GA32099@sudip-PC> References: <1426771061-28103-1-git-send-email-sudipm.mukherjee@gmail.com> <20150319132236.GA3540@kroah.com> <20150319140328.GA31838@sudip-PC> <20150319141539.GD7046@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150319141539.GD7046@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 03:15:39PM +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 19, 2015 at 07:33:28PM +0530, Sudip Mukherjee wrote: > > On Thu, Mar 19, 2015 at 02:22:36PM +0100, Greg Kroah-Hartman wrote: > > place. > > I suggest to leave it, it's not costing anything to keep around, and I > think you removed additional code with this patch anyway, which wasn't > good... fine, then please discard this series. additional code means only a chip comparison for SM718 which this driver donot have any support for. ohh, and one request, I have some patches pending for staging/sm7xxfb and staging/panel, if you please review, and if ok, apply them then i can send the followon patches. regards sudip > > thanks, > > greg k-h