Re: [PATCH] signal: improve warning about using SI_TKILL in rt_[tg]sigqueueinfo

Oleg Nesterov
2015-03-19T15:06:37Z

On 03/19, Vladimir Davydov wrote:
>
> On Thu, Mar 19, 2015 at 02:00:46PM +0100, Oleg Nesterov wrote:
> >
> > Agreed.
> >
> > but perhaps we can simply remove this warning at all?
>
> We can, I suppose. Personally, I do not have any strong preference.

Me too, but personally I like this version more ;)

> From: Vladimir Davydov <vdavydov@parallels.com>
> Subject: [PATCH] signal: remove warning about using SI_TKILL in
> rt_[tg]sigqueueinfo
>
> Sending SI_TKILL from rt_[tg]sigqueueinfo was deprecated, so now we
> issue a warning on the first attempt of doing it. We use WARN_ON_ONCE,
> which is not informative and, what is worse, taints the kernel, making
> the trinity syscall fuzzer complain false-positively from time to time.
>
> It does not look like we need this warning at all, because the behaviour
> changed quite a long time ago (2.6.39), and if an application relies on
> the old API, it gets EPERM anyway and can issue a warning by itself.
>
> So let us zap the warning in kernel.
>
> Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>

Acked-by: Oleg Nesterov <oleg@redhat.com>