From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756225AbbCSPGh (ORCPT ); Thu, 19 Mar 2015 11:06:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35160 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755820AbbCSPGf (ORCPT ); Thu, 19 Mar 2015 11:06:35 -0400 Date: Thu, 19 Mar 2015 16:04:28 +0100 From: Oleg Nesterov To: Vladimir Davydov Cc: linux-kernel@vger.kernel.org, Andrew Morton , Richard Weinberger , "Paul E. McKenney" Subject: Re: [PATCH] signal: improve warning about using SI_TKILL in rt_[tg]sigqueueinfo Message-ID: <20150319150427.GA12624@redhat.com> References: <1426758781-11746-1-git-send-email-vdavydov@parallels.com> <20150319130045.GA7201@redhat.com> <20150319143341.GG29416@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150319143341.GG29416@esperanza> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/19, Vladimir Davydov wrote: > > On Thu, Mar 19, 2015 at 02:00:46PM +0100, Oleg Nesterov wrote: > > > > Agreed. > > > > but perhaps we can simply remove this warning at all? > > We can, I suppose. Personally, I do not have any strong preference. Me too, but personally I like this version more ;) > From: Vladimir Davydov > Subject: [PATCH] signal: remove warning about using SI_TKILL in > rt_[tg]sigqueueinfo > > Sending SI_TKILL from rt_[tg]sigqueueinfo was deprecated, so now we > issue a warning on the first attempt of doing it. We use WARN_ON_ONCE, > which is not informative and, what is worse, taints the kernel, making > the trinity syscall fuzzer complain false-positively from time to time. > > It does not look like we need this warning at all, because the behaviour > changed quite a long time ago (2.6.39), and if an application relies on > the old API, it gets EPERM anyway and can issue a warning by itself. > > So let us zap the warning in kernel. > > Signed-off-by: Vladimir Davydov Acked-by: Oleg Nesterov