From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753300AbbCSPgs (ORCPT ); Thu, 19 Mar 2015 11:36:48 -0400 Received: from mail.skyhub.de ([78.46.96.112]:35985 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbbCSPgn (ORCPT ); Thu, 19 Mar 2015 11:36:43 -0400 Date: Thu, 19 Mar 2015 16:35:06 +0100 From: Borislav Petkov To: Tejun Heo Cc: Dmitry Torokhov , Doug Thompson , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, Mauro Carvalho Chehab , Tetsuo Handa , Olof Johansson , Arjan van de Ven , Greg Kroah-Hartman , "Luis R . Rodriguez" Subject: Re: [PATCH 3/3] EDAC: amd64_edac: decide if driver can load successfully early. Message-ID: <20150319153505.GD11715@pd.tnic> References: <1426726150-983-1-git-send-email-dmitry.torokhov@gmail.com> <1426726150-983-4-git-send-email-dmitry.torokhov@gmail.com> <20150319094054.GC10860@pd.tnic> <20150319152957.GI25365@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150319152957.GI25365@htj.duckdns.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 11:29:57AM -0400, Tejun Heo wrote: > This is a gloss layering violation. Please don't do things like this. > I'm all for ripping out the hack even w/o considering the async probe > issue. And I don't want to leave the driver loaded when there's nothing to be loaded for. One instance in this driver's specific case is one northbridge and there are numascale boxes with hundreds of northbridges. If you have a better idea about how to unload the driver, asynchronously or not, after all probe() calls have failed, I'm all ears. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --