From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754563AbbCSQCH (ORCPT ); Thu, 19 Mar 2015 12:02:07 -0400 Received: from muru.com ([72.249.23.125]:38620 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753823AbbCSQCB (ORCPT ); Thu, 19 Mar 2015 12:02:01 -0400 Date: Thu, 19 Mar 2015 08:57:20 -0700 From: Tony Lindgren To: Matthijs van Duin Cc: Bin Liu , Felipe Balbi , Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, "linux-omap@vger.kernel.org" , linux-usb , Brian Hutchinson Subject: Re: [PATCH] phy: Add a driver for dm816x USB PHY Message-ID: <20150319155719.GD31346@atomide.com> References: <20150309212622.GJ5264@atomide.com> <20150309214129.GK5264@atomide.com> <20150313193058.GN5264@atomide.com> <20150316164951.GR5264@atomide.com> <20150317021919.GA31346@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Matthijs van Duin [150319 04:20]: > On 17 March 2015 at 03:19, Tony Lindgren wrote: > > Yes so it seem here too, this is dm816x rev c, what do you have? > > jtag ID reads 0x1b81e02f, so that would be rev 1.1 / rev A. > > > Anyways, I'll add a note that at least rev c does not seems to do > > anything with USB_CTRL but that we follow what the TI tree is doing > > in case some other revisions of the hardware use it. > > Another idea would be to check if it's nonzero and if so, yell loudly > in the kernel log that they should mail the linux-omap list ;-) Sure I'll add that to the phy start up code :) Regards, Tony