Re: [PATCH 3/3] EDAC: amd64_edac: decide if driver can load successfully early.

Borislav Petkov
2015-03-19T16:46:49Z

On Thu, Mar 19, 2015 at 12:33:30PM -0400, Tejun Heo wrote:
> Please stop shell scripting in your ->probe() in kernel.

I don't think you understand me: I'm not going to shell script in my
->probe() function. This is what I'm going to do:

init():

for each northbridge {
check if northbridge has ecc;
}

if no northbridge has ecc {
return;
}

pci_register_driver();

Now this is clean and doesn't violate any models. It is basically a
check whether the driver should load or not. What's wrong with that, for
chrissake?

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--