From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753693AbbCSQ57 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 19 Mar 2015 12:57:59 -0400
Received: from mail-ie0-f181.google.com ([209.85.223.181]:35730 "EHLO
	mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751234AbbCSQ54 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 19 Mar 2015 12:57:56 -0400
Date: Thu, 19 Mar 2015 09:57:41 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>, Doug Thompson <dougthompson@xmission.com>,
        linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
        Olof Johansson <olof@lixom.net>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Luis R . Rodriguez" <mcgrof@suse.com>
Subject: Re: [PATCH 3/3] EDAC: amd64_edac: decide if driver can load
 successfully early.
Message-ID: <20150319165741.GH30732@dtor-ws>
References: <1426726150-983-1-git-send-email-dmitry.torokhov@gmail.com>
 <1426726150-983-4-git-send-email-dmitry.torokhov@gmail.com>
 <20150319094054.GC10860@pd.tnic>
 <20150319152957.GI25365@htj.duckdns.org>
 <20150319153505.GD11715@pd.tnic>
 <20150319155553.GK25365@htj.duckdns.org>
 <20150319160132.GG11715@pd.tnic>
 <20150319161241.GL25365@htj.duckdns.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150319161241.GL25365@htj.duckdns.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 19, 2015 at 12:12:41PM -0400, Tejun Heo wrote:
> On Thu, Mar 19, 2015 at 05:01:32PM +0100, Borislav Petkov wrote:
> > On Thu, Mar 19, 2015 at 11:55:53AM -0400, Tejun Heo wrote:
> > <snip needless schooling on driver core>
> > 
> > > This code is standing in the way of a much more impactful generic
> > > driver layer improvement.
> > 
> > So why not mark it as synchronously loading and forget about it?
> 
> Isn't that obvious?  Because hacks like this are likely to cause other
> problems down the road and set bad precedences.

In all fairness platform_driver_probe() does pretty much the same and
forces us to mark thus drivers with PROBE_FORCE_SYNCHRONOUS as well. And
there are quite a few of them:

dtor@dtor-ws:~/kernel/work$ grep -r "platform_driver_probe" drivers/ |
wc -l
186

What makes edac unusual is that PCI bus is hot-pluggable and thus PCI
drivers are rarely one-shot.

Thanks.

-- 
Dmitry