From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755343AbbCSRDq (ORCPT ); Thu, 19 Mar 2015 13:03:46 -0400 Received: from mail-vc0-f179.google.com ([209.85.220.179]:33452 "EHLO mail-vc0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbbCSRDm (ORCPT ); Thu, 19 Mar 2015 13:03:42 -0400 Date: Thu, 19 Mar 2015 13:03:39 -0400 From: Tejun Heo To: Borislav Petkov Cc: Dmitry Torokhov , Doug Thompson , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, Mauro Carvalho Chehab , Tetsuo Handa , Olof Johansson , Arjan van de Ven , Greg Kroah-Hartman , "Luis R . Rodriguez" Subject: Re: [PATCH 3/3] EDAC: amd64_edac: decide if driver can load successfully early. Message-ID: <20150319170339.GP25365@htj.duckdns.org> References: <20150319152957.GI25365@htj.duckdns.org> <20150319153505.GD11715@pd.tnic> <20150319155253.GA30732@dtor-ws> <20150319155953.GF11715@pd.tnic> <20150319161226.GC30732@dtor-ws> <20150319162301.GH11715@pd.tnic> <20150319163330.GN25365@htj.duckdns.org> <20150319164506.GJ11715@pd.tnic> <20150319164908.GO25365@htj.duckdns.org> <20150319165619.GL11715@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150319165619.GL11715@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 05:56:20PM +0100, Borislav Petkov wrote: > I don't see anything wrong with that and I don't see how that would > repeat any iteration... Just don't do it. It makes the driver behave differently from others for no good reason. Driver being loaded or not doesn't indicate anything anymore other than the code is loaded and you're adding complexity to just make it more confusing and you don't have good enough technical reasons to justify the deviation. What are you even fighting for? -- tejun