From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756510AbbCSRLR (ORCPT ); Thu, 19 Mar 2015 13:11:17 -0400 Received: from mta-out1.inet.fi ([62.71.2.203]:58802 "EHLO kirsi1.inet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751242AbbCSRLO (ORCPT ); Thu, 19 Mar 2015 13:11:14 -0400 Date: Thu, 19 Mar 2015 19:10:43 +0200 From: "Kirill A. Shutemov" To: "Aneesh Kumar K.V" Cc: "Kirill A. Shutemov" , Andrew Morton , Andrea Arcangeli , Dave Hansen , Hugh Dickins , Mel Gorman , Rik van Riel , Vlastimil Babka , Christoph Lameter , Naoya Horiguchi , Steve Capper , Johannes Weiner , Michal Hocko , Jerome Marchand , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 00/24] THP refcounting redesign Message-ID: <20150319171043.GA10658@node.dhcp.inet.fi> References: <1425486792-93161-1-git-send-email-kirill.shutemov@linux.intel.com> <8761a0arki.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8761a0arki.fsf@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2015 at 03:12:05PM +0530, Aneesh Kumar K.V wrote: > "Kirill A. Shutemov" writes: > > > Hello everybody, > > > > It's bug-fix update of my thp refcounting work. > > > > The goal of patchset is to make refcounting on THP pages cheaper with > > simpler semantics and allow the same THP compound page to be mapped with > > PMD and PTEs. This is required to get reasonable THP-pagecache > > implementation. > > > > With the new refcounting design it's much easier to protect against > > split_huge_page(): simple reference on a page will make you the deal. > > It makes gup_fast() implementation simpler and doesn't require > > special-case in futex code to handle tail THP pages. > > > > It should improve THP utilization over the system since splitting THP in > > one process doesn't necessary lead to splitting the page in all other > > processes have the page mapped. > > I tested this patch on ppc64 and verified thp allocation and split. > I also checked the subpage_prot and it worked as expected. I will > run more tests with this series and update if I find any issues. Thanks a lot. Could you also prepare patch to drop power-specific code related to pmd_trans_splitting()? It's not needed anymore with the patchset. -- Kirill A. Shutemov