From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751192AbbCSSli (ORCPT ); Thu, 19 Mar 2015 14:41:38 -0400 Received: from haggis.mythic-beasts.com ([93.93.131.52]:47469 "EHLO haggis.mythic-beasts.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854AbbCSSlb (ORCPT ); Thu, 19 Mar 2015 14:41:31 -0400 X-Greylist: delayed 3211 seconds by postgrey-1.27 at vger.kernel.org; Thu, 19 Mar 2015 14:41:31 EDT Date: Thu, 19 Mar 2015 17:47:56 +0000 From: henrix@camandro.org To: Luis Henriques Cc: Jens Axboe , linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: drop extra (and bogus) printk Message-ID: <20150319174756.GD21530@charon.olymp> References: <1424991408-3110-1-git-send-email-luis.henriques@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1424991408-3110-1-git-send-email-luis.henriques@canonical.com> X-BlackCat-Spam-Score: -28 X-Mythic-Debug: Threshold = On = Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping? I've sent these 3 patches almost a month ago... Cheers, -- Luís On Thu, Feb 26, 2015 at 10:56:48PM +0000, Luis Henriques wrote: > When setting an invalid scheduler through sysfs, two log entries will be > added. Also, when running 'echo foo > /sys/block/DISK/queue/scheduler' > the second one will includes the extra '\n': > > [10465.216944] elevator: type foo not found > [10465.216953] elevator: switch to foo > failed > > This patch simply drops the second printk(). > > Signed-off-by: Luis Henriques > --- > block/elevator.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/elevator.c b/block/elevator.c > index 59794d0d38e3..0ac9ea519201 100644 > --- a/block/elevator.c > +++ b/block/elevator.c > @@ -997,7 +997,6 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name, > if (!ret) > return count; > > - printk(KERN_ERR "elevator: switch to %s failed\n", name); > return ret; > } > > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/