[PATCH] block: drop extra (and bogus) printk

[PATCH] block: drop extra (and bogus) printk

[Luis Henriques]

When setting an invalid scheduler through sysfs, two log entries will be
added.  Also, when running 'echo foo > /sys/block/DISK/queue/scheduler'
the second one will includes the extra '\n':

[10465.216944] elevator: type foo not found
[10465.216953] elevator: switch to foo
 failed

This patch simply drops the second printk().

Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
---
 block/elevator.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/elevator.c b/block/elevator.c
index 59794d0d38e3..0ac9ea519201 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -997,7 +997,6 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
 	if (!ret)
 		return count;
 
-	printk(KERN_ERR "elevator: switch to %s failed\n", name);
 	return ret;
 }
 
-- 
2.1.4

Re: [PATCH] block: drop extra (and bogus) printk

[henrix]

Ping?  I've sent these 3 patches almost a month ago...

Cheers,
--
Luís

On Thu, Feb 26, 2015 at 10:56:48PM +0000, Luis Henriques wrote:
> When setting an invalid scheduler through sysfs, two log entries will be
> added.  Also, when running 'echo foo > /sys/block/DISK/queue/scheduler'
> the second one will includes the extra '\n':
> 
> [10465.216944] elevator: type foo not found
> [10465.216953] elevator: switch to foo
>  failed
> 
> This patch simply drops the second printk().
> 
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> ---
>  block/elevator.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/elevator.c b/block/elevator.c
> index 59794d0d38e3..0ac9ea519201 100644
> --- a/block/elevator.c
> +++ b/block/elevator.c
> @@ -997,7 +997,6 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
>  	if (!ret)
>  		return count;
>  
> -	printk(KERN_ERR "elevator: switch to %s failed\n", name);
>  	return ret;
>  }
>  
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/