From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753950AbbCSS3S (ORCPT ); Thu, 19 Mar 2015 14:29:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39850 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751804AbbCSS3P (ORCPT ); Thu, 19 Mar 2015 14:29:15 -0400 Date: Thu, 19 Mar 2015 14:29:02 -0400 From: Benjamin Tissoires To: Dmitry Torokhov Cc: Yves-Alexis Perez , Andrew Duggan , Hans de Goede , Peter Hutterer , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time! Message-ID: <20150319182902.GA19505@mail.corp.redhat.com> References: <1423253075-23469-1-git-send-email-benjamin.tissoires@redhat.com> <20150319142450.GA1641@balvenie> <20150319144627.GA18134@mail.corp.redhat.com> <20150319152526.GA3651@balvenie> <20150319155830.GB18134@mail.corp.redhat.com> <20150319164746.GA1648@balvenie> <20150319170649.GE18134@mail.corp.redhat.com> <20150319174359.GK30732@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150319174359.GK30732@dtor-ws> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mar 19 2015 or thereabouts, Dmitry Torokhov wrote: > On Thu, Mar 19, 2015 at 01:06:49PM -0400, Benjamin Tissoires wrote: > > On Mar 19 2015 or thereabouts, Yves-Alexis Perez wrote: > > > On Thu, Mar 19, 2015 at 11:58:31AM -0400, Benjamin Tissoires wrote: > > > > On Mar 19 2015 or thereabouts, Yves-Alexis Perez wrote: > > > > Again, sorry, I thought I answered it. With the kernel patches applied: > > > > - disabled in the bios without psmouse.proto=imps -> touchpad still > > > > enabled, trackstick + buttons working > > > > - disabling in the bios + psmouse.proto=imps -> touchpad disabled, > > > > trackstick + buttons working > > > > - enabled in the bios + psmouse.proto=imps -> touchpad barely usable, > > > > trackstick + buttons working > > > > > > > > That should cover all the cases :) > > > > > > > Actually, one is missing: “touchpad enabled / without > > > psmouse.proto=imps”, but it doesn't really matter for me since I'm not > > > using the touchpad anyway. > > > > Yes, but that is the most used case, and if this one was not working > > then the patch series would have been moot :) > > > > > > > > But that also means if I want a disabled touchpad (without using xinput > > > disable) I'm forced to use psmouse.proto=imps. It does work fine but I > > > then lose the speed and sensitivity attributes (in > > > /sys/devices/platform/i8042/...) and the Trackpoint device itself is > > > gone from the input subsystem (everything goes to the touchpad one). > > > > > > I find that a bit confusing, and think it'd be best if the touchpad > > > disabling could be handled even when IMPS/2 is not used, but maybe it's > > > impossible to do? > > It is possible, but that task is on Lenovo's BIOS engineers to > implement. The kernel queries the device and responds accordingly; there > is no separate "check BIOS settings" pass. "proto=imps" simply tells > psmouse driver to skip the advanced protocol "magic knocks" and try > initalize mouse as MS Intellimouse compatible device. > > I'd be curious to compare i8042 data (i8042.debug) from booting with > both proto=imps and without (note that keystrokes for your password will > be recorded there if you decide to post the logs), but again just for > curiosity's sake as I wonder how exactly they done disabling that it > only works for Intellimouse mode. > There you go: http://people.freedesktop.org/~tissoire/boot_bios_disabled_with_imps.txt http://people.freedesktop.org/~tissoire/boot_bios_disabled_no_imps.txt An no, there is no trace of my password on this, I carefully ssh to the box to extract the logs :) Cheers, Benjamin > Thanks. > > -- > Dmitry