From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751427AbbCSUVm (ORCPT ); Thu, 19 Mar 2015 16:21:42 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:46459 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbbCSUVk (ORCPT ); Thu, 19 Mar 2015 16:21:40 -0400 Date: Thu, 19 Mar 2015 23:21:24 +0300 From: Dan Carpenter To: Michel von Czettritz Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: fixing multiple checkpatch errors and warnings Message-ID: <20150319202124.GW10964@mwanda> References: <20150319192603.GA26974@x230-arch.club.entropia.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150319192603.GA26974@x230-arch.club.entropia.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 08:26:03PM +0100, Michel von Czettritz wrote: > This patch formats sm750.c to > - correct intendations > - no leading or trailing whitespaces > - no C99 Style comments > - correct braces and spacings for if, for and functions > - no initalisation of static variables to 0 or NULL > - no assignments in if conditions > - correct spacings arround pointers and function arguments > > and some other warnings This patch does too many things at once. Split it up into one type of warning per patch. regards, dan carpenter