From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751281AbbCTF2M (ORCPT ); Fri, 20 Mar 2015 01:28:12 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47631 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750801AbbCTF2J (ORCPT ); Fri, 20 Mar 2015 01:28:09 -0400 Date: Thu, 19 Mar 2015 22:28:07 -0700 From: Stephen Boyd To: Archit Taneja Cc: mturquette@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: qcom: fix RCG M/N counter configuration Message-ID: <20150320052807.GA11451@codeaurora.org> References: <1425462575-11486-1-git-send-email-architt@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425462575-11486-1-git-send-email-architt@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04, Archit Taneja wrote: > Currently, a RCG's M/N counter (used for fraction division) is set to either > 'bypass' (counter disabled) or 'dual edge' (counter enabled) based on whether > the corresponding rcg struct has a mnd field specified and a non-zero N. > > In the case where M and N are the same value, the M/N counter is still enabled > by code even though no division takes place. Leaving the RCG in such a state > can result in improper behavior. This was observed with the DSI pixel clock RCG > when M and N were both set to 1. > > Add an additional check (M != N) to enable the M/N counter only when it's needed > for fraction division. > > Signed-off-by: Archit Taneja > --- I'm going to queue this up for 4.1 given that this isn't a new regression. But I'll tag it for stable so that we get it into all the stable trees. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project