From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Clark Williams" <williams@redhat.com>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
"Mike Galbraith" <umgwanakikbuti@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"Jörn Engel" <joern@purestorage.com>
Subject: Re: [PATCH v5] sched/rt: Use IPI to trigger RT task push migration instead of pulling
Date: Fri, 20 Mar 2015 11:25:42 +0100 [thread overview]
Message-ID: <20150320102542.GY23123@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150318144946.2f3cc982@gandalf.local.home>
On Wed, Mar 18, 2015 at 02:49:46PM -0400, Steven Rostedt wrote:
> +static int find_next_push_cpu(struct rq *rq)
> +{
> + struct rq *next_rq;
> + int cpu;
> +
> + while (1) {
We typically tend to write: for (;;), instead, however would a do { }
while () loop not make more sense here?
do {
cpu = rto_next_cpu(rq);
if (cpu >= nr_cpu_ids)
break;
next_rq = cpu_rq(cpu);
} while (next_rq->rt.highest_prio.next >= rq->rt.highest_prio.curr);
> + return cpu;
> +}
next prev parent reply other threads:[~2015-03-20 10:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 18:49 [PATCH v5] sched/rt: Use IPI to trigger RT task push migration instead of pulling Steven Rostedt
2015-03-20 10:25 ` Peter Zijlstra [this message]
2015-03-20 14:27 ` Steven Rostedt
2015-03-20 10:31 ` Peter Zijlstra
2015-03-20 14:30 ` Steven Rostedt
2015-03-26 1:24 ` Wanpeng Li
2015-03-27 16:14 ` Steven Rostedt
2015-03-23 12:25 ` [tip:sched/core] " tip-bot for Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320102542.GY23123@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=joern@purestorage.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=umgwanakikbuti@gmail.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox