From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751991AbbCTOlO (ORCPT ); Fri, 20 Mar 2015 10:41:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40725 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbbCTOlJ (ORCPT ); Fri, 20 Mar 2015 10:41:09 -0400 Date: Fri, 20 Mar 2015 13:18:12 +0100 From: Greg Kroah-Hartman To: Brian Russell Cc: "Hans J. Koch" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] uio: Fix uio driver to refcount device Message-ID: <20150320121812.GA26764@kroah.com> References: <550B0D90.2010202@brocade.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <550B0D90.2010202@brocade.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 05:55:28PM +0000, Brian Russell wrote: > Protect uio driver from its owner being unplugged while there are open fds. > Embed struct device in struct uio_device, use refcounting on device, free > uio_device on release. > info struct passed in uio_register_device can be freed on unregister, so null > out the field in uio_unregister_device and check accesses. > > Signed-off-by: Brian Russell > --- > drivers/uio/uio.c | 58 +++++++++++++++++++++++++++++++--------------- > include/linux/uio_driver.h | 2 +- > 2 files changed, 40 insertions(+), 20 deletions(-) This patch is line-wrapped and can not be applied :( Please fix up your email client and resend. I've applied the first patch, which worked just fine, no need to resend it. thanks, greg k-h