From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbbCTOmQ (ORCPT ); Fri, 20 Mar 2015 10:42:16 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40778 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbbCTOmN (ORCPT ); Fri, 20 Mar 2015 10:42:13 -0400 Date: Fri, 20 Mar 2015 13:48:43 +0100 From: Greg KH To: Ameen Ali Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404. Message-ID: <20150320124843.GA26504@kroah.com> References: <1424882058-2880-1-git-send-email-ameenali023@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424882058-2880-1-git-send-email-ameenali023@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 25, 2015 at 06:34:18PM +0200, Ameen Ali wrote: > else if at line 406 has the same condition as the else if at line 404. > i chosed 0x5 because it's half 0xb (just a rate controller) > Signed-off-by : Ameen Ali > --- > drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) How do you know this is correct? Also, we need a blank line before the signed-off-by line and your subject should give us a chance to know what driver is being changed, as well as the subsystem. Also, where are patches 1/3 and 2/3? thanks, greg k-h