From: Greg KH <gregkh@linuxfoundation.org>
To: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>,
sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sm750fb: Fix Comment and if else braces
Date: Fri, 20 Mar 2015 14:04:19 +0100 [thread overview]
Message-ID: <20150320130419.GB23287@kroah.com> (raw)
In-Reply-To: <550B11C0.1030300@gmail.com>
On Thu, Mar 19, 2015 at 08:13:20PM +0200, Giedrius Statkevičius wrote:
> Hi Amitoj Kaur Chawla,
>
> On 2015.03.19 20:05, Amitoj Kaur Chawla wrote:
> > The edits have been made to add a space before the comment and the errors in
> > braces in the if-else statements.
> > Previously in commit 2d34f53f1065878cd881ac61a183f8e836583d51, removed
> > the C99 comments and errors in if-else indentation and braces.
>
> The previous patch isn't in the git repo yet so it doesn't have a commit
> id thus this one is wrong. You should've just made a v2 and made that
> change. I recommend you to look over this:
> http://kernelnewbies.org/FirstKernelPatch Just remove the HEAD commit in
> your local git repo, add that space and then when using `git
> format-patch` use the "--subject-prefix" option to add that it's a
> second version. Then after "---" you can say what was changed in the
> second version. For example (I'm sure you can think of a better one!):
>
> Signed-off-by: ...
> ---
> v2: added a space after a statement in a line where a coding style error
> was fixed.
>
> drivers/...
Yes, please resend both of these.
thanks,
greg k-h
prev parent reply other threads:[~2015-03-20 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 18:05 [PATCH] sm750fb: Fix Comment and if else braces Amitoj Kaur Chawla
2015-03-19 18:13 ` Giedrius Statkevičius
2015-03-20 13:04 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320130419.GB23287@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amitoj1606@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=giedrius.statkevicius@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox