From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752569AbbCTOr3 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 Mar 2015 10:47:29 -0400
Received: from mail-la0-f44.google.com ([209.85.215.44]:35698 "EHLO
	mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751773AbbCTOrY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 Mar 2015 10:47:24 -0400
Date: Fri, 20 Mar 2015 17:47:20 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Denys Vlasenko <vda.linux@googlemail.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Pavel Emelyanov <xemul@parallels.com>, Andrey Wagin <avagin@gmail.com>,
        Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Andi Kleen <andi@firstfloor.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Al Viro <viro@zeniv.linux.org.uk>, X86 ML <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>, Pavel Emelyanov <xemul@openvz.org>
Subject: Re: [PATCH v3 1/2] x86_64,signal: Fix SS handling for signals
 delivered to 64-bit programs
Message-ID: <20150320144720.GW27066@moon>
References: <CANaxB-ySx5R6-9yBGSEpr9iO+FDZDuiP_PNMYJihHAUDiVAoAg@mail.gmail.com>
 <20150318200247.GA6355@redhat.com>
 <CALCETrXzGb+5sBNhoD+mC7mYGBiAmtzj=jMo7R=gdsThuPHPUg@mail.gmail.com>
 <5509EF82.60900@parallels.com>
 <CALCETrWWU-izMJ688HP8_V6OLfN5V8+W0E-RGhRR=yBOUaYecQ@mail.gmail.com>
 <20150319073512.GA27066@moon>
 <CAK1hOcPXcjuqsLkb1x2qJcj5MEoc9beC2tzR_GpuGwL1wkgAAg@mail.gmail.com>
 <20150320115622.GR27066@moon>
 <20150320120419.GS27066@moon>
 <20150320140738.GA12509@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150320140738.GA12509@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 20, 2015 at 03:07:38PM +0100, Oleg Nesterov wrote:
> 
> Another downside (to me) is that this special case can help, but only
> "by accident".
> 
> For example, criu has ->ss = 0, but it was not initialized explicitly.
> 
> But as I said, I won't argue.

OK, after talking to Pavel -- it's fine to require new criu version
for new kernels, thus lets leave kernel pure without this special
hack, moreover now we have a fix from Oleg merged into criu so we
should be safe. Thanks a lot for all comments!