From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751265AbbCTQFd (ORCPT ); Fri, 20 Mar 2015 12:05:33 -0400 Received: from mail.skyhub.de ([78.46.96.112]:56854 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123AbbCTQFS (ORCPT ); Fri, 20 Mar 2015 12:05:18 -0400 Date: Fri, 20 Mar 2015 17:03:37 +0100 From: Borislav Petkov To: Aravind Gopalakrishnan Cc: "Luck, Tony" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "slaoub@gmail.com" , "luto@amacapital.net" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: Re: [PATCH] x86, mce, severities: Add AMD severities function Message-ID: <20150320160337.GE17058@pd.tnic> References: <20150317102048.GG19645@pd.tnic> <5508756A.1090908@amd.com> <20150317184441.GI19645@pd.tnic> <3908561D78D1C84285E8C5FCA982C28F32A234ED@ORSMSX114.amr.corp.intel.com> <20150319092953.GB10860@pd.tnic> <550ADFFD.2090708@amd.com> <20150319155345.GE11715@pd.tnic> <550AF743.8070906@amd.com> <3908561D78D1C84285E8C5FCA982C28F32A23E9C@ORSMSX114.amr.corp.intel.com> <550C43E5.4090302@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <550C43E5.4090302@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 20, 2015 at 10:59:33AM -0500, Aravind Gopalakrishnan wrote: > Ok, Here's how I have it currently: > void __init mcheck_vendor_init_severity(void) > { > struct cpuinfo_x86 *c = &boot_cpu_data; > > switch (c->x86_vendor) { > case X86_VENDOR_INTEL: > mce_severity = mce_severity_intel; > break; > case X86_VENDOR_AMD: > mce_severity = mce_severity_amd; > break; > default: > break; > } > } > And I call this from mcheck_init(). > I tested the above bits on AMD and the severities grading works fine. > > Should we also come up with a '_default' function to assign to mce_severity > function pointer? I think that should be default: WARN_ONCE("WTF?!"); break; above. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --