From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752096AbbCTStX (ORCPT ); Fri, 20 Mar 2015 14:49:23 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:50441 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752069AbbCTStV (ORCPT ); Fri, 20 Mar 2015 14:49:21 -0400 Date: Fri, 20 Mar 2015 21:49:09 +0300 From: Dan Carpenter To: Matteo Semenzato Cc: gregkh@linuxfoundation.org, navin.patidar@gmail.com, hejianet@gmail.com, sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtl8188eu fix buffer overflow Message-ID: <20150320184909.GY10964@mwanda> References: <1426861300-13286-1-git-send-email-mattew8898@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426861300-13286-1-git-send-email-mattew8898@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 20, 2015 at 03:21:40PM +0100, Matteo Semenzato wrote: > From: Matteo Semenzato > > This patch fixes the buffer overflow caused by accessing index 4 of hwxmits. > This is a Smatch warning? It's a false positive because the code that accesses hwxmits[4] is dead code. Just delete it that section. regards, dan carpenter