From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751658AbbCVCaA (ORCPT <rfc822;w@1wt.eu>);
	Sat, 21 Mar 2015 22:30:00 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:56778 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751468AbbCVC36 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 21 Mar 2015 22:29:58 -0400
From: Arnd Bergmann <arnd@linaro.org>
Organization: Linaro Ltd
To: Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net-next V2 04/23] ptp: blackfin: convert to the 64 bit get/set time methods.
Date: Sun, 22 Mar 2015 03:28:46 +0100
User-Agent: KMail/1.12.2 (Linux/3.8.0-35-generic; KDE/4.3.2; x86_64; ; )
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Amir Vadai <amirv@mellanox.com>, Ariel Elior <ariel.elior@qlogic.com>,
        Baolin Wang <baolin.wang@linaro.org>,
        Ben Hutchings <ben@decadent.org.uk>,
        Bruce Allan <bruce.w.allan@intel.com>,
        Carolyn Wyborny <carolyn.wyborny@intel.com>,
        Chris Metcalf <cmetcalf@ezchip.com>,
        David Miller <davem@davemloft.net>, Frank Li <Frank.Li@freescale.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        John Stultz <john.stultz@linaro.org>,
        Luwei Zhou <b45643@freescale.com>,
        Matthew Vick <matthew.vick@intel.com>,
        Michael Chan <mchan@broadcom.com>,
        Prashant Sreedharan <prashant@broadcom.com>,
        Shradha Shah <sshah@solarflare.com>,
        Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
        Sonic Zhang <sonic.zhang@analog.com>,
        Stefan =?iso-8859-15?q?S=F8rensen?= 
	<stefan.sorensen@spectralink.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Tom Lendacky <thomas.lendacky@amd.com>
References: <cover.1426973658.git.richardcochran@gmail.com> <d60e40f5c008cf85a764f958d5b692f167cd05ba.1426973658.git.richardcochran@gmail.com>
In-Reply-To: <d60e40f5c008cf85a764f958d5b692f167cd05ba.1426973658.git.richardcochran@gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201503220328.46415.arnd@linaro.org>
X-Provags-ID: V03:K0:fpSFmcuZpT1GpTnKgb3KbKMEQExQrTOjLf6WkBrojlqETyAxinP
 6nAxvNWEG0VLkSv7AlCZas9ob+z6ffoKP9wDsvLTkJWMpLNHXSlTASCBkAkwSDq22L3UoHW
 a3JfwHpT9J02+y263NIwKIQBz4CrqnVoa4uwsqYL8L8SIrkpwuw6KHHVN39y3XJaE2hPe3c
 0BuKxZ03Cr+N0Upv461/Q==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Saturday 21 March 2015, Richard Cochran wrote:
> -static int bfin_ptp_gettime(struct ptp_clock_info *ptp, struct timespec *ts)
> +static int bfin_ptp_gettime(struct ptp_clock_info *ptp, struct timespec64 *ts)
>  {
>         u64 ns;
>         u32 remainder;

I think it would be good to replace the open-coded 

        ns = ts->tv_sec * 1000000000ULL;
        ns += ts->tv_nsec;

here with a call to ns_to_timespec64(), here and in other drivers that you
are already touching.

	Arnd