From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751720AbbCVCh1 (ORCPT <rfc822;w@1wt.eu>);
	Sat, 21 Mar 2015 22:37:27 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:62297 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751607AbbCVCh0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 21 Mar 2015 22:37:26 -0400
From: Arnd Bergmann <arnd@linaro.org>
Organization: Linaro Ltd
To: Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.
Date: Sun, 22 Mar 2015 03:36:31 +0100
User-Agent: KMail/1.12.2 (Linux/3.8.0-35-generic; KDE/4.3.2; x86_64; ; )
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Amir Vadai <amirv@mellanox.com>, Ariel Elior <ariel.elior@qlogic.com>,
        Baolin Wang <baolin.wang@linaro.org>,
        Ben Hutchings <ben@decadent.org.uk>,
        Bruce Allan <bruce.w.allan@intel.com>,
        Carolyn Wyborny <carolyn.wyborny@intel.com>,
        Chris Metcalf <cmetcalf@ezchip.com>,
        David Miller <davem@davemloft.net>, Frank Li <Frank.Li@freescale.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        John Stultz <john.stultz@linaro.org>,
        Luwei Zhou <b45643@freescale.com>,
        Matthew Vick <matthew.vick@intel.com>,
        Michael Chan <mchan@broadcom.com>,
        Prashant Sreedharan <prashant@broadcom.com>,
        Shradha Shah <sshah@solarflare.com>,
        Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
        Sonic Zhang <sonic.zhang@analog.com>,
        Stefan =?iso-8859-15?q?S=F8rensen?= 
	<stefan.sorensen@spectralink.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Tom Lendacky <thomas.lendacky@amd.com>
References: <cover.1426973658.git.richardcochran@gmail.com> <55b6ec7c2e0c72a79762748981fad2ce2497f22d.1426973658.git.richardcochran@gmail.com>
In-Reply-To: <55b6ec7c2e0c72a79762748981fad2ce2497f22d.1426973658.git.richardcochran@gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201503220336.31836.arnd@linaro.org>
X-Provags-ID: V03:K0:OjpAJzEWOmRiMNge67PEZWsncYHjUzevJmlwmjm6XNLN3CdPpl5
 VbnCd4Lvgx0k2pugpYstrNOilFs36RwGVUBB4b8cM1xIFlfx/y80MgSN6Qz5dAlOEcsmutw
 5jD7udJyB7HdDW+G0sKDqyCqGnrLIgnhb6mX3TBxamasktNP0j+/gaJ+PZu9lR/CkhpzFnO
 qbaj2gsYxCUTf+O2GLbsw==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Saturday 21 March 2015, Richard Cochran wrote:
>         mutex_lock(&clock->extreg_lock);
>  
> -       err = tdr_write(1, phydev, ts, PTP_LOAD_CLK);
> +       err = tdr_write(1, phydev, &ts, PTP_LOAD_CLK);
>  
>         mutex_unlock(&clock->extreg_lock);

I don't see the change to the tdr_write() function that changes the 
argument from 'struct timespec ts' to 'struct timespec64 *', so this
looks wrong to me.

	Arnd