From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752824AbbCVKTn (ORCPT <rfc822;w@1wt.eu>);
	Sun, 22 Mar 2015 06:19:43 -0400
Received: from mail-wi0-f177.google.com ([209.85.212.177]:35907 "EHLO
	mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752122AbbCVKTh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 22 Mar 2015 06:19:37 -0400
Date: Sun, 22 Mar 2015 11:19:33 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Corey Ashford <cjashfor@linux.vnet.ibm.com>,
        David Ahern <david.ahern@oracle.com>,
        Namhyung Kim <namhyung@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 14/31] perf build: Rename PERF-FEATURES into FEATURE-DUMP
Message-ID: <20150322101932.GA2255@gmail.com>
References: <1426784707-19466-1-git-send-email-acme@kernel.org>
 <1426784707-19466-15-git-send-email-acme@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426784707-19466-15-git-send-email-acme@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> From: Jiri Olsa <jolsa@kernel.org>
> 
> Preparing for feature checks separation, moving related stuff under
> 'FEATURE*' namespace.
> 
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: David Ahern <david.ahern@oracle.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Link: http://lkml.kernel.org/n/tip-v9oo22ra70rrk1dy495a7bjc@git.kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

So I think the various capital letter files in $(cwd) are highly 
suboptimal:

 FEATURE-DUMP
 PERF-CFLAGS
 PERF-VERSION-FILE

I think we should standardize on something less pushy (no shouting), 
plus more standardized, more logical, more coherent names, i.e. 
something like:

   .build.features.cache
   .build.cflags
   .build.version

?

.build.features.* would be reserved to the generic feature detection 
machinery.

.build.cflags and .build.version could be used by the perf build - 
hopefully exported to tools/build/ as well in the future! :-)

That way the .gitignore could just ignore .build.* and we'd not have 
to update it much.

Btw., another small nit: could we please do a (git-)rename of 
tools/build/feature/ to tools/build/features/?

Plural is what is used typically for generic frameworks that deal with 
a set of items (features in this case) - for example we have 
tools/tests/, and tools/perf/scripts/, not tools/test/ and 
tools/perf/script/.

Thanks,

	Ingo