From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751982AbbCVUJn (ORCPT <rfc822;w@1wt.eu>);
	Sun, 22 Mar 2015 16:09:43 -0400
Received: from vps0.lunn.ch ([178.209.37.122]:54631 "EHLO vps0.lunn.ch"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751748AbbCVUJm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 22 Mar 2015 16:09:42 -0400
Date: Sun, 22 Mar 2015 21:06:00 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Guenter Roeck <linux@roeck-us.net>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/18] net: dsa: mv88e6xxx: Add Hardware bridging support
Message-ID: <20150322200600.GD15025@lunn.ch>
References: <1426952815-4642-1-git-send-email-linux@roeck-us.net>
 <1426952815-4642-9-git-send-email-linux@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426952815-4642-9-git-send-email-linux@roeck-us.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Guenter

> +static int _mv88e6xxx_atu_cmd(struct dsa_switch *ds, int fid, u16 cmd)
> +{
> +	int ret;
> +
> +	ret = _mv88e6xxx_reg_write(ds, REG_GLOBAL, 0x01, fid);
> +	if (ret < 0)
> +		return ret;

Please could you check this. I think register 0x01 here is wrong. I
think you want 0x0b, the ATU Operations register?

Thanks
	Andrew

> +
> +	ret = _mv88e6xxx_reg_write(ds, REG_GLOBAL, 0x0b, cmd);
> +	if (ret < 0)
> +		return ret;
> +
> +	return _mv88e6xxx_atu_wait(ds);
> +}
> +