From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752141AbbCWAv3 (ORCPT ); Sun, 22 Mar 2015 20:51:29 -0400 Received: from LGEMRELSE6Q.lge.com ([156.147.1.121]:42811 "EHLO lgemrelse6q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752019AbbCWAv1 (ORCPT ); Sun, 22 Mar 2015 20:51:27 -0400 X-Original-SENDERIP: 10.177.220.203 X-Original-MAILFROM: namhyung@kernel.org Date: Mon, 23 Mar 2015 09:44:33 +0900 From: Namhyung Kim To: Yunlong Song Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org, wangnan0@huawei.com Subject: Re: [PATCH] perf tools: Remove (null) value of "Sort order" for perf mem report Message-ID: <20150323004433.GD2782@sejong> References: <1426773512-27350-1-git-send-email-yunlong.song@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1426773512-27350-1-git-send-email-yunlong.song@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yunlong, On Thu, Mar 19, 2015 at 09:58:32PM +0800, Yunlong Song wrote: > When '--sort' is not set, 'perf mem report" will print a null pointer as > the output value of sort order, so fix it. > > Example: > > Before this patch: > > $ perf mem report > # To display the perf.data header info, please use --header/--header-only options. > # > # Samples: 18 of event 'cpu/mem-loads/pp' > # Total weight : 188 > # Sort order : (null) > # > ... > > After this patch: > > $ perf mem report > # To display the perf.data header info, please use --header/--header-only options. > # > # Samples: 18 of event 'cpu/mem-loads/pp' > # Total weight : 188 > # > ... I think it'd be better to show default sort order in this case. > > Signed-off-by: Yunlong Song > --- > tools/perf/builtin-report.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > index 52f74e1..918ffef 100644 > --- a/tools/perf/builtin-report.c > +++ b/tools/perf/builtin-report.c > @@ -304,7 +304,8 @@ static size_t hists__fprintf_nr_sample_events(struct hists *hists, struct report > > if (rep->mem_mode) { > ret += fprintf(fp, "\n# Total weight : %" PRIu64, nr_events); > - ret += fprintf(fp, "\n# Sort order : %s", sort_order); > + if (sort_order) > + ret += fprintf(fp, "\n# Sort order : %s", sort_order); Something like this? ret += fprintf(fp, "\n# Sort order : %s", sort_order ?: default_mem_sort_order); Thanks, Namhyung > } else > ret += fprintf(fp, "\n# Event count (approx.): %" PRIu64, nr_events); > return ret + fprintf(fp, "\n#\n"); > -- > 1.8.5.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/