From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752035AbbCWCzy (ORCPT <rfc822;w@1wt.eu>);
	Sun, 22 Mar 2015 22:55:54 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:42788 "EHLO
	relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751907AbbCWCzw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 22 Mar 2015 22:55:52 -0400
X-Originating-IP: 50.43.43.179
Date: Sun, 22 Mar 2015 19:55:43 -0700
From: Josh Triplett <josh@joshtriplett.org>
To: Sanidhya Kashyap <sanidhya.gatech@gmail.com>
Cc: reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Kashyap, Sanidhya" <sanidhya@gatech.edu>
Subject: Re: [PATCH] reiserfs: kstrdup() memory handling
Message-ID: <20150323025543.GA2120@thin>
References: <1426957213-5508-1-git-send-email-sanidhya.gatech@gmail.com>
 <20150321171547.GA5663@thin>
 <CADa969h6MLbM3vporSjkctBxQwsqphghbXQxAhtyBUeUuqrWQA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CADa969h6MLbM3vporSjkctBxQwsqphghbXQxAhtyBUeUuqrWQA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Mar 22, 2015 at 08:12:46PM -0400, Sanidhya Kashyap wrote:
> On Sat, Mar 21, 2015 at 1:15 PM, Josh Triplett <josh@joshtriplett.org> wrote:
> > On Sat, Mar 21, 2015 at 01:00:13PM -0400, Sanidhya Kashyap wrote:
> >> Checking for ENOMEM even for new_opts in reiserfs_remount function as
> >> there is a possibility of nothing being allocated.
> >
> > You don't need to add a new label; kfree(NULL) is a no-op.
> >
> 
> Shall I resubmit the patch?

I would suggest doing so, yes, after you see if anyone else has feedback
on it.

- Josh Triplett